Bug 260756 - AX: Implement test_driver_internal.{get_computed_role, get_computed_label}
Summary: AX: Implement test_driver_internal.{get_computed_role, get_computed_label}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-25 19:01 PDT by Tyler Wilcock
Modified: 2023-08-28 14:49 PDT (History)
12 users (show)

See Also:

Attachments
Patch (239.26 KB, patch)
2023-08-25 19:06 PDT, Tyler Wilcock 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (253.13 KB, patch)
2023-08-25 23:03 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (254.05 KB, patch)
2023-08-26 10:35 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (257.25 KB, patch)
2023-08-26 16:17 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (257.26 KB, patch)
2023-08-28 10:10 PDT, Tyler Wilcock 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (257.26 KB, patch)
2023-08-28 10:27 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2023-08-25 19:01:27 PDT 
This is necessary to run accessibility WPTs via the WebKitTestRunner.
Comment 1 Radar WebKit Bug Importer 2023-08-25 19:01:38 PDT 
<rdar://problem/114480911>
Comment 2 Tyler Wilcock 2023-08-25 19:06:25 PDT 
Created attachment 467448 [details]
Patch
Comment 3 Tyler Wilcock 2023-08-25 23:03:23 PDT 
Created attachment 467450 [details]
Patch
Comment 4 Tyler Wilcock 2023-08-26 10:35:30 PDT 
Created attachment 467451 [details]
Patch
Comment 5 Tyler Wilcock 2023-08-26 16:17:48 PDT 
Created attachment 467453 [details]
Patch
Comment 6 chris fleizach 2023-08-27 23:16:20 PDT 
Comment on attachment 467453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467453&action=review

> Source/WebCore/testing/Internals.cpp:7161
> +AccessibilityObject* Internals::axObjectFor(Element& element) const

is this style of naming used in WebKit? I would have expected the name to be axObjectForElement

> Source/WebCore/testing/Internals.cpp:7198
> +    return element.renderer() || !element.rendererIsNeeded(*computedStyle);

we've already checked element.renderer() above. do we need to check it here too?
Comment 7 Tyler Wilcock 2023-08-28 10:10:14 PDT 
Created attachment 467459 [details]
Patch
Comment 8 Tyler Wilcock 2023-08-28 10:27:54 PDT 
Created attachment 467460 [details]
Patch
Comment 9 EWS 2023-08-28 14:49:21 PDT 
Committed 267364@main (33b030f32890): <https://commits.webkit.org/267364@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467460 [details].