Bug 260766 - Use 'ScrollSetting' enum in 'VTTRegion.idl' align with IDL Spec
Summary: Use 'ScrollSetting' enum in 'VTTRegion.idl' align with IDL Spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anne van Kesteren
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-25 23:49 PDT by Ahmad Saleem
Modified: 2023-09-10 06:06 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-08-25 23:49:52 PDT 
SSIA

As per Web-Spec: https://www.w3.org/TR/webvtt1/#the-vttregion-interface

In Web-Spec, we have:

enum ScrollSetting { "" /* none */, "up" };

and then have changed below as well:

attribute [AtomString] DOMString scroll; <- this to: attribute ScrollSetting scroll;

_

Just raising, so we can fix it.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-09-01 23:50:14 PDT 
<rdar://problem/114859668>
Comment 2 Anne van Kesteren 2023-09-09 09:39:04 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17626
Comment 3 EWS 2023-09-10 06:06:34 PDT 
Committed 267842@main (48210b2e0db4): <https://commits.webkit.org/267842@main>

Reviewed commits have been landed. Closing PR #17626 and removing active labels.