Bug 260776 - [IFC] Use opaque InlineItem to compute out-of-flow static position
Summary: [IFC] Use opaque InlineItem to compute out-of-flow static position
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-27 09:52 PDT by zalan
Modified: 2023-08-30 09:30 PDT (History)
5 users (show)

See Also:

Attachments
Patch (45.49 KB, patch)
2023-08-27 09:57 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (48.92 KB, patch)
2023-08-27 19:25 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (34.52 KB, patch)
2023-08-28 12:37 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (36.91 KB, patch)
2023-08-28 15:14 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (36.97 KB, patch)
2023-08-28 15:49 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (39.60 KB, patch)
2023-08-28 19:36 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (39.57 KB, patch)
2023-08-28 20:34 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (38.93 KB, patch)
2023-08-29 07:20 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (41.12 KB, patch)
2023-08-30 07:31 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-08-27 09:52:13 PDT 
ssia
Comment 1 zalan 2023-08-27 09:57:32 PDT 
Created attachment 467454 [details]
Patch
Comment 2 zalan 2023-08-27 19:25:29 PDT 
Created attachment 467455 [details]
Patch
Comment 3 zalan 2023-08-28 12:37:39 PDT 
Created attachment 467468 [details]
Patch
Comment 4 zalan 2023-08-28 15:14:34 PDT 
Created attachment 467470 [details]
Patch
Comment 5 zalan 2023-08-28 15:49:23 PDT 
Created attachment 467472 [details]
Patch
Comment 6 zalan 2023-08-28 19:36:25 PDT 
Created attachment 467476 [details]
Patch
Comment 7 zalan 2023-08-28 20:34:26 PDT 
Created attachment 467478 [details]
Patch
Comment 8 Antti Koivisto 2023-08-28 22:54:27 PDT 
Comment on attachment 467478 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467478&action=review

> COMMIT_MESSAGE:6
> +Let's replace existing out-of-flow handling with using opaque inline items instead.

Nice!

> Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:884
> +    auto formattingContext = this->formattingContext();

Does this purposefully create a copy of the formatting context?
Comment 9 zalan 2023-08-29 07:14:26 PDT 
(In reply to Antti Koivisto from comment #8)
> Comment on attachment 467478 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467478&action=review
> 
> > COMMIT_MESSAGE:6
> > +Let's replace existing out-of-flow handling with using opaque inline items instead.
> 
> Nice!
> 
> > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:884
> > +    auto formattingContext = this->formattingContext();
> 
> Does this purposefully create a copy of the formatting context?
certainly not! good catch!
Comment 10 zalan 2023-08-29 07:20:33 PDT 
Created attachment 467481 [details]
Patch
Comment 11 zalan 2023-08-30 07:31:05 PDT 
Created attachment 467491 [details]
Patch
Comment 12 EWS 2023-08-30 09:29:17 PDT 
Committed 267456@main (bac664c02d19): <https://commits.webkit.org/267456@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467491 [details].
Comment 13 Radar WebKit Bug Importer 2023-08-30 09:30:17 PDT 
<rdar://problem/114705938>