Bug 260779 - WorkQueue should inherit from SerialFunctionDispatcher
Summary: WorkQueue should inherit from SerialFunctionDispatcher
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-27 15:58 PDT by Jean-Yves Avenard [:jya]
Modified: 2023-09-05 03:53 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2023-08-27 15:58:33 PDT 
Right now `WorkQueue` and `ConcurrentWorkQueue` both inherit from `WorkQueueBase` which inherits from `FunctionDispatcher`.

But like a `RunLoop` or a `WorkerOrWorkletThread`, a `WorkQueue` is a `SerialFunctionDispatcher`. As such it should inherit from that instead.
Comment 1 Radar WebKit Bug Importer 2023-08-27 15:58:49 PDT 
<rdar://problem/114535523>
Comment 2 Jean-Yves Avenard [:jya] 2023-08-31 18:15:36 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17318
Comment 3 EWS 2023-09-05 03:52:56 PDT 
Committed 267623@main (4cc06b4be14a): <https://commits.webkit.org/267623@main>

Reviewed commits have been landed. Closing PR #17318 and removing active labels.