Bug 260831 - [git-webkit] Correctly parse EWS data in PR body
Summary: [git-webkit] Correctly parse EWS data in PR body
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-28 16:15 PDT by Jonathan Bedard
Modified: 2023-08-29 09:44 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-08-28 16:15:10 PDT 
EWS adds to the body of every PR. webkitscmpy has code which attempts to parse the body of a PR to seperate the original commit message of the commits involved in a PR. webkitscmpy should have always excluded the EWS data from it's parsed body, but we never updated our regexes to ensure that happens.
Comment 1 Radar WebKit Bug Importer 2023-08-28 16:15:26 PDT 
<rdar://problem/114593055>
Comment 2 Jonathan Bedard 2023-08-28 16:28:57 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17156
Comment 3 EWS 2023-08-29 09:44:27 PDT 
Committed 267409@main (9f045b69d7e0): <https://commits.webkit.org/267409@main>

Reviewed commits have been landed. Closing PR #17156 and removing active labels.