Bug 260903 - [IFC][Coverage] Remove margin-trim check
Summary: [IFC][Coverage] Remove margin-trim check
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-30 07:33 PDT by zalan
Modified: 2023-09-07 06:30 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.81 KB, patch)
2023-08-30 07:41 PDT, zalan 		koivisto: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
[fast-cq]Patch (8.07 KB, patch)
2023-09-06 20:45 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-08-30 07:33:04 PDT 
it does not apply.
Comment 1 zalan 2023-08-30 07:41:28 PDT 
Created attachment 467492 [details]
Patch
Comment 2 zalan 2023-08-30 08:58:56 PDT 
Comment on attachment 467492 [details]
Patch

Apparently float-only cases need some work.
Comment 3 Radar WebKit Bug Importer 2023-09-06 07:34:14 PDT 
<rdar://problem/115055358>
Comment 4 zalan 2023-09-06 20:45:42 PDT 
Created attachment 467579 [details]
[fast-cq]Patch
Comment 5 EWS Watchlist 2023-09-06 20:51:23 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 6 Tim Nguyen (:ntim) 2023-09-06 21:19:47 PDT 
Comment on attachment 467579 [details]
[fast-cq]Patch

If the WPT changes need to be done upstream, please run `export-w3c-test-changes -b 260903 -g HEAD -c --no-linter` to export them, otherwise they'll be lost at the next import.
Comment 7 zalan 2023-09-07 06:28:18 PDT 
(In reply to Tim Nguyen (:ntim) from comment #6)
> Comment on attachment 467579 [details]
> [fast-cq]Patch
> 
> If the WPT changes need to be done upstream, please run
> `export-w3c-test-changes -b 260903 -g HEAD -c --no-linter` to export them,
> otherwise they'll be lost at the next import.
they don't (pending on float margin trim feature removal)
Comment 8 EWS 2023-09-07 06:30:38 PDT 
Committed 267725@main (f70985fd068f): <https://commits.webkit.org/267725@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467579 [details].