Bug 260931 - Timers are not coalesced during thermal throttling; should match low power mode
Summary: Timers are not coalesced during thermal throttling; should match low power mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-30 16:17 PDT by Tim Horton
Modified: 2023-08-30 23:56 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2023-08-30 16:17:30 PDT 
Timers are not coalesced during thermal throttling; should match low power mode
Comment 1 Tim Horton 2023-08-30 16:18:28 PDT 
<rdar://problem/112725366>
Comment 2 Tim Horton 2023-08-30 16:21:23 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17257
Comment 3 EWS 2023-08-30 19:45:16 PDT 
Committed 267480@main (30884546903f): <https://commits.webkit.org/267480@main>

Reviewed commits have been landed. Closing PR #17257 and removing active labels.
Comment 4 Diego Pino 2023-08-30 22:03:57 PDT 
https://build.webkit.org/#/builders/596/builds/12635

WPE Ubuntu 20.04 started failing after this patch. There was a unified sources build error due to duplicated enum 'None' (conflicts with X Window headers).

```
FAILED: 
In file included from /usr/include/X11/Xlib.h:44,
                 from /usr/include/EGL/eglplatform.h:128,
                 from /usr/include/epoxy/egl_generated.h:11,
                 from /usr/include/epoxy/egl.h:46,
                 from ../../Source/WebCore/platform/graphics/epoxy/EpoxyEGL.h:28,
                 from ../../Source/WebCore/platform/graphics/egl/GLContext.cpp:30,
                 from WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-43.cpp:1:
../../Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h:36:5: error: expected identifier before numeric constant
   36 |     None
      |     ^~~~
```
Comment 5 Diego Pino 2023-08-30 22:04:33 PDT 
Re-opening for pull request https://github.com/webkit/webkit/pull/17272
Comment 6 EWS 2023-08-30 23:56:02 PDT 
Committed 267487@main (07585903a5d3): <https://commits.webkit.org/267487@main>

Reviewed commits have been landed. Closing PR #17272 and removing active labels.