Bug 260955 - WebGLFramebuffer uses renderbuffer and texture attachments via WebGLObject
Summary: WebGLFramebuffer uses renderbuffer and texture attachments via WebGLObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-31 01:32 PDT by Kimmo Kinnunen
Modified: 2023-08-31 17:50 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2023-08-31 01:32:32 PDT 
WebGLFramebuffer uses renderbuffer  and texture attachments via WebGLObject

- Forces the code to be less safe than needed
- Gets in the way of not having renderbuffers and textures share a common base class
- Needs "isRenderbuffer(), isTexture()" disambiguation in base class
Comment 1 Radar WebKit Bug Importer 2023-08-31 01:32:58 PDT 
<rdar://problem/114750589>
Comment 2 Kimmo Kinnunen 2023-08-31 01:48:23 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17282
Comment 3 EWS 2023-08-31 17:50:11 PDT 
Committed 267535@main (0dcc7a680e6c): <https://commits.webkit.org/267535@main>

Reviewed commits have been landed. Closing PR #17282 and removing active labels.