Bug 260996 - maybePauseDisplayRefreshCallbacks doesn't wait for MissedCommit
Summary: maybePauseDisplayRefreshCallbacks doesn't wait for MissedCommit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-08-31 14:17 PDT by Matt Woodrow
Modified: 2023-09-04 18:15 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-08-31 14:17:31 PDT 
<rdar://114606581>

maybePauseDisplayRefreshCallbacks is pausing callbacks if nothing is in NeedsDisplayDidRefresh, but we also want to keep callbacks enabled for CommitLayerTreePending so that we transition to MissedCommit state.
Comment 1 Matt Woodrow 2023-08-31 14:20:35 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17304
Comment 2 EWS 2023-09-04 18:15:26 PDT 
Committed 267614@main (dae026f290e6): <https://commits.webkit.org/267614@main>

Reviewed commits have been landed. Closing PR #17304 and removing active labels.