Bug 261022 - [TextureMapper] Move filter specific code from BitmapTextureGL to TextureMapperGL
Summary: [TextureMapper] Move filter specific code from BitmapTextureGL to TextureMapp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 231653
  Show dependency tree / graph
 
Reported: 2023-09-01 00:48 PDT by Akihiro Kiuchi
Modified: 2023-09-03 18:36 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Akihiro Kiuchi 2023-09-01 00:48:00 PDT 
This is a preparation refactoring for https://bugs.webkit.org/show_bug.cgi?id=231653.

To fix the issue above, we have to change the number of passes needed to do blur filtering according to the standard deviation of the blur.
Now the number of passes for each filter is specified in BitmapTextureGL.cpp but other parameters regarding filtering such as shader options are specified in TextureMapperGL.cpp, which leads to the inconsistency and low readability.

My suggestion is to move the loop of passes, written in BitmapTextureGL.cpp for now, to TextureMapperGL.cpp
Comment 1 Fujii Hironori 2023-09-01 13:53:56 PDT 
PR https://github.com/WebKit/WebKit/pull/17335
Comment 2 EWS 2023-09-03 18:35:33 PDT 
Committed 267599@main (499bdf98d4a7): <https://commits.webkit.org/267599@main>

Reviewed commits have been landed. Closing PR #17335 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-09-03 18:36:13 PDT 
<rdar://problem/114912332>