Bug 261025 - Allow using longer ancestor chains in StyleCustomPropertyData
Summary: Allow using longer ancestor chains in StyleCustomPropertyData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-01 04:18 PDT by Antti Koivisto
Modified: 2023-09-03 10:01 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2023-09-01 04:18:27 PDT 
Currently only one ancestor is allowed. It is typical to have many properties defined on :root. If we more definition further down into the tree in multiple levels then all those properties get copied and we can get large maps duplicated to many elements. This also makes equality comparisons slow.
Comment 1 Radar WebKit Bug Importer 2023-09-01 04:18:42 PDT 
<rdar://problem/114815380>
Comment 2 Antti Koivisto 2023-09-01 04:30:19 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17338
Comment 3 EWS 2023-09-03 10:01:32 PDT 
Committed 267595@main (8b7bc22a8c87): <https://commits.webkit.org/267595@main>

Reviewed commits have been landed. Closing PR #17338 and removing active labels.