Bug 261044 - Some code incorrectly compares Document objects using CSSParserContext's comparison operator
Summary: Some code incorrectly compares Document objects using CSSParserContext's comp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-01 13:09 PDT by Chris Dumez
Modified: 2023-09-01 22:09 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-09-01 13:09:11 PDT 
Mark CSSParserContext constructors as explicit. We have some code incorrectly comparing Document objects by value and the code builds because it is implicitly converting the Documents to CSSParserContexts and calling CSSParserContext's operator==().
Comment 1 Chris Dumez 2023-09-01 13:38:49 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17356
Comment 2 EWS 2023-09-01 22:08:15 PDT 
Committed 267577@main (1dc257f3194c): <https://commits.webkit.org/267577@main>

Reviewed commits have been landed. Closing PR #17356 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-09-01 22:09:16 PDT 
<rdar://problem/114857465>