Bug 261066 - Handle NaN in the Audio delay curves
Summary: Handle NaN in the Audio delay curves
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: Safari 16
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-02 10:37 PDT by Ahmad Saleem
Modified: 2023-09-02 15:54 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-09-02 10:37:26 PDT
Hi Team,

Based on Slack's discussion with Chris 1:1, it is potential merge from Blink:

Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/f6e3d4665d9261e4fef2b5931e4c75ecb5e032bf

WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp#124

______

It is fixed by following:

        double delayTime = m_delayTimes[i];
        if (std::isnan(delayTime))
            delayTime = maxDelayTime();
        else
            delayTime = std::clamp<double>(m_delayTimes[i], 0.0, maxDelayTime());

____

Raising this bug so we can fix it in WebKit as well.

Thanks!
Comment 1 EWS 2023-09-02 15:53:31 PDT
Committed 267589@main (138a64742ac6): <https://commits.webkit.org/267589@main>

Reviewed commits have been landed. Closing PR #17377 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-09-02 15:54:13 PDT
<rdar://problem/114881060>