WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
261067
Check for NaN when creating a DelayNode for WebAudio
https://bugs.webkit.org/show_bug.cgi?id=261067
Summary
Check for NaN when creating a DelayNode for WebAudio
Ahmad Saleem
Reported
2023-09-02 11:57:10 PDT
Hi Team, I think it would be good to merge this and also update 'Layout Test' for 'NaN' check. Blink Commit:
https://chromium.googlesource.com/chromium/src.git/+/c8c4a710be6292a220177fef0c3f1c7c7853d062
WebKit Source:
https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/DelayNode.cpp#55
&
https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp#75
___ Test Output: PASS context.createDelay(NaN) threw exception TypeError: The provided value is non-finite. ___ Just wanted to raise to get opinion whether we should merge it or not. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Karl Dubost
Comment 1
2023-09-04 17:50:59 PDT
https://wpt.fyi/results/webaudio/the-audio-api/the-delaynode-interface?label=master&label=experimental&aligned&q=delaynode%20
Karl Dubost
Comment 2
2023-09-04 17:54:19 PDT
https://searchfox.org/wubkat/rev/68e96f24aae90f5a0a5e0c56c932c93616766cc7/Source/WebCore/Modules/webaudio/DelayNode.cpp#50-67
Maybe it's already checked in some ways.
EWS
Comment 3
2023-09-05 13:50:57 PDT
Committed
267650@main
(5736f9dd89ea): <
https://commits.webkit.org/267650@main
> Reviewed commits have been landed. Closing PR #17379 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2023-09-05 13:51:19 PDT
<
rdar://problem/115008784
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug