Bug 261067 - Check for NaN when creating a DelayNode for WebAudio
Summary: Check for NaN when creating a DelayNode for WebAudio
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: Safari 16
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar
Depends on:
Blocks:
 
Reported: 2023-09-02 11:57 PDT by Ahmad Saleem
Modified: 2023-09-05 13:51 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-09-02 11:57:10 PDT 
Hi Team,

I think it would be good to merge this and also update 'Layout Test' for 'NaN' check.

Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/c8c4a710be6292a220177fef0c3f1c7c7853d062

WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/DelayNode.cpp#55 & https://searchfox.org/wubkat/source/Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp#75

___

Test Output:

PASS context.createDelay(NaN) threw exception TypeError: The provided value is non-finite.

___

Just wanted to raise to get opinion whether we should merge it or not.

Thanks!
Comment 3 EWS 2023-09-05 13:50:57 PDT 
Committed 267650@main (5736f9dd89ea): <https://commits.webkit.org/267650@main>

Reviewed commits have been landed. Closing PR #17379 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-09-05 13:51:19 PDT 
<rdar://problem/115008784>