Bug 261082 - AutoInstaller unable to install beautifulsoup4 4.12.2 (no PEP 517 build system support)
Summary: AutoInstaller unable to install beautifulsoup4 4.12.2 (no PEP 517 build syste...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-03 05:06 PDT by Sam Sneddon [:gsnedders]
Modified: 2023-11-23 14:31 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2023-09-03 05:06:42 PDT
This packages relies on PEP 517 (https://peps.python.org/pep-0517/) being properly implemented; while Jonathan implemented a hackish workaround with bug 253066 that works for some packages, it doesn't work for bs4 which declares in its pyproject.toml:

[build-system]
requires = ["hatchling"]
build-backend = "hatchling.build"

I still feel like us having to reimplement more and more of the Python packaging ecosystem is likely fragile, and we should simply leverage more existing tools (whether by calling pip from the autoinstaller, or by vendoring packages such as build).
Comment 1 Michael Catanzaro 2023-09-03 07:10:54 PDT
So https://github.com/WebKit/WebKit/pull/17201 uses this version of bs4 and it works for me. That's strange.
Comment 2 Sam Sneddon [:gsnedders] 2023-09-03 07:52:41 PDT
(In reply to Michael Catanzaro from comment #1)
> So https://github.com/WebKit/WebKit/pull/17201 uses this version of bs4 and
> it works for me. That's strange.

My first guess is somehow our hacky workaround from bug 253066 suffices with the version of setuptools we have on Python 3.8+: https://github.com/WebKit/WebKit/blob/5ea837d2ce2e325744ef5d63d11e1c41e8a2c5e8/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py#L61-L62