Bug 261088 - Cleanup convertingToLengthHasRequiredConversionData after 267590@main
Summary: Cleanup convertingToLengthHasRequiredConversionData after 267590@main
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-03 13:21 PDT by Tim Nguyen (:ntim)
Modified: 2023-09-03 21:09 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2023-09-03 13:21:22 PDT 
Now that computedStyleDependencies collects viewport units dependencies, we can clean up convertingToLengthHasRequiredConversionData and stop traversing recursively in the calc() case (since computedStyleDependencies already does so).
Comment 1 Radar WebKit Bug Importer 2023-09-03 13:21:49 PDT 
<rdar://problem/114906119>
Comment 2 Tim Nguyen (:ntim) 2023-09-03 13:24:50 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17387
Comment 3 EWS 2023-09-03 21:09:25 PDT 
Committed 267601@main (6044332a1ccc): <https://commits.webkit.org/267601@main>

Reviewed commits have been landed. Closing PR #17387 and removing active labels.