Bug 261091 - RemoteImageBufferProxy::ensureBackendCreated can wait for a message that isn't pending
Summary: RemoteImageBufferProxy::ensureBackendCreated can wait for a message that isn'...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-03 14:33 PDT by Matt Woodrow
Modified: 2023-09-05 01:25 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-09-03 14:33:26 PDT 
<rdar://114795818>

ensureBackendCreated waits for the DidCreateBackend message to be delivered, but it's possible for the GPUP to have crashed and been recreated since the request was made, and thus the message will never arrive.

We make new requests for backends in RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed, so it should be fine to just fail to return a backend in the meantime.
Comment 1 Matt Woodrow 2023-09-03 14:50:53 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17390
Comment 2 EWS 2023-09-05 01:25:14 PDT 
Committed 267619@main (df7a74a8f788): <https://commits.webkit.org/267619@main>

Reviewed commits have been landed. Closing PR #17390 and removing active labels.