Bug 261101 - [TextureMapper] Shrink texture before applying large radius blur
Summary: [TextureMapper] Shrink texture before applying large radius blur
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 231653 261102
  Show dependency treegraph
 
Reported: 2023-09-04 00:27 PDT by Akihiro Kiuchi
Modified: 2023-09-21 15:32 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Akihiro Kiuchi 2023-09-04 00:27:23 PDT
This is a sub issue of https://bugs.webkit.org/show_bug.cgi?id=231653

As Bug231653 pointed out, current blurring causes a mosaic artifacts when the blur radius is large.

The promissing solution is to shrink the texture before applying blur filter and expand again, which seems a common technique and skia uses it as well.
ref: https://github.com/google/skia/blob/0f9e50daa87997d376bf5fb60b06ab5b15c63ed9/src/gpu/ganesh/GrBlurUtils.cpp#L2580-L2586.

This is the main sub issue of Bug231653 but separeted from Bug231653 because But231653 will includes additional refactoring issue and performance issue.
Comment 1 Akihiro Kiuchi 2023-09-04 20:03:50 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17419
Comment 2 EWS 2023-09-05 13:08:50 PDT
Committed 267646@main (57b05d82091b): <https://commits.webkit.org/267646@main>

Reviewed commits have been landed. Closing PR #17419 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-09-05 13:09:15 PDT
<rdar://problem/115004547>