Bug 261103 - Upgrading to setuptools >= 60 breaks Genshi install
Summary: Upgrading to setuptools >= 60 breaks Genshi install
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-04 01:42 PDT by Sam Sneddon [:gsnedders]
Modified: 2023-10-09 03:36 PDT (History)
1 user (show)

See Also:

Attachments
build log (12.45 KB, text/plain)
2023-09-04 01:42 PDT, Sam Sneddon [:gsnedders] 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2023-09-04 01:42:00 PDT 
Created attachment 467536 [details]
build log

c.f. https://github.com/edgewall/genshi/pull/68

This doesn't actually happen if you build using the modern build toolchain, but does happen if you build using setup.py directly.
Comment 1 Sam Sneddon [:gsnedders] 2023-09-04 02:26:29 PDT 
It seems like nothing uses Genshi so the simple fix here may well be to just remove its registration? Like, it only gets installed when running test-webkitpy because that calls AutoInstall.install_everything.
Comment 2 Radar WebKit Bug Importer 2023-09-11 01:42:14 PDT 
<rdar://problem/115276376>
Comment 3 Sam Sneddon [:gsnedders] 2023-10-09 03:36:06 PDT 
(In reply to Sam Sneddon [:gsnedders] from comment #1)
> It seems like nothing uses Genshi so the simple fix here may well be to just
> remove its registration? Like, it only gets installed when running
> test-webkitpy because that calls AutoInstall.install_everything.

This was done as part of 268856@main, bug 260877.

Given this bug is really specific to Genshi being broken by setuptools (unlike most of our dependency upgrade bugs), there's no reason to keep this open.