Bug 261127 - Let the compiler generate more comparison operators in JSC
Summary: Let the compiler generate more comparison operators in JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-04 16:56 PDT by Chris Dumez
Modified: 2023-11-16 13:13 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-09-04 16:56:52 PDT 
Let the compiler generate more comparison operators in JSC now that we support C++20.
Comment 1 Chris Dumez 2023-09-04 16:58:32 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17417
Comment 2 EWS 2023-09-05 12:41:17 PDT 
Committed 267645@main (e9e93692891c): <https://commits.webkit.org/267645@main>

Reviewed commits have been landed. Closing PR #17417 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-09-05 12:42:15 PDT 
<rdar://problem/115001681>
Comment 4 Chris Dumez 2023-11-16 09:38:15 PST 
This caused a 3MB binary size increase and I am unclear why. The compiler should in theory generate identical code to the one we had..

At first I thought it was because I newly inlined 2 of the comparison operators. However, moving them back out of line didn't reduce binary size significantly.
Comment 5 Darin Adler 2023-11-16 13:13:21 PST 
Maybe the generated ones are always implicitly generated inline?