Bug 261152 - REGRESSION(267569@main?): WasmB3IRGenerator.h:59:21: error: use of undeclared identifier 'BBQDisassembler'
Summary: REGRESSION(267569@main?): WasmB3IRGenerator.h:59:21: error: use of undeclared...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-05 06:17 PDT by Michael Catanzaro
Modified: 2023-09-05 07:34 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-09-05 06:17:02 PDT 
In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk4/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-7.cpp:2:
In file included from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmWorklist.cpp:33:
In file included from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmPlan.h:31:
/home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmB3IRGenerator.h:59:21: error: use of undeclared identifier 'BBQDisassembler'
    std::unique_ptr<BBQDisassembler> bbqDisassembler;
                    ^
/home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmB3IRGenerator.h:65:343: error: unknown type name 'TierUpCount'
Expected<std::unique_ptr<InternalFunction>, String> parseAndCompileB3(CompilationContext&, OptimizingJITCallee&, const FunctionData&, const TypeDefinition&, Vector<UnlinkedWasmToWasmCall>&, const ModuleInformation&, MemoryMode, CompilationMode, uint32_t functionIndex, std::optional<bool> hasExceptionHandlers, uint32_t loopIndexForOSREntry, TierUpCount* = nullptr);
Comment 1 Michael Catanzaro 2023-09-05 06:21:41 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17434
Comment 2 EWS 2023-09-05 07:33:57 PDT 
Committed 267628@main (e57e1d07f2ce): <https://commits.webkit.org/267628@main>

Reviewed commits have been landed. Closing PR #17434 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-09-05 07:34:15 PDT 
<rdar://problem/114981403>