Bug 261163 - Simplify the CodeGeneratorExtensions.pm generated code for the most common optional argument case
Summary: Simplify the CodeGeneratorExtensions.pm generated code for the most common op...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Extensions (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-05 09:17 PDT by Timothy Hatcher
Modified: 2023-09-06 14:50 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2023-09-05 09:17:44 PDT 
The generator outputs complex argument handling code in all cases, when it can be simplified for common 2 and 3 argument cases when the last argument is optional.
Comment 1 Radar WebKit Bug Importer 2023-09-05 09:17:52 PDT 
<rdar://problem/114986995>
Comment 2 Timothy Hatcher 2023-09-05 10:31:36 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17446
Comment 3 EWS 2023-09-06 14:50:07 PDT 
Committed 267695@main (77ea37f47bee): <https://commits.webkit.org/267695@main>

Reviewed commits have been landed. Closing PR #17446 and removing active labels.