Bug 261235 - Add a WKWebPushToolMain for webpushtool to use
Summary: Add a WKWebPushToolMain for webpushtool to use
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-06 15:23 PDT by Brady Eidson
Modified: 2023-09-07 15:44 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2023-09-06 15:23:27 PDT 
Upcoming work requires webpushtool code to properly be inside the WebKit build, so let's just have it work like our daemons do, with an exported WKMain function
Comment 1 Radar WebKit Bug Importer 2023-09-06 15:23:41 PDT 
<rdar://problem/115079480>
Comment 2 Brady Eidson 2023-09-06 15:26:32 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17507
Comment 3 EWS 2023-09-06 20:15:59 PDT 
Committed 267714@main (a12bd8488608): <https://commits.webkit.org/267714@main>

Reviewed commits have been landed. Closing PR #17507 and removing active labels.
Comment 4 youenn fablet 2023-09-07 06:01:19 PDT 
This seems to break my command line build (USE_WORKSPACE=NO make r).
Comment 5 EWS 2023-09-07 08:28:20 PDT 
Committed 267732@main (e0822d5cf7c5): <https://commits.webkit.org/267732@main>

Reviewed commits have been landed. Closing PR #17544 and removing active labels.
Comment 6 Brady Eidson 2023-09-07 14:08:08 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/17553
Comment 7 Brady Eidson 2023-09-07 14:10:06 PDT 
This broke production builds (And presumably the specific type of command line build Youenn did) because there were still some things left in the "webpushtool" target in the Xcode project.

Clearing them out so it's just the .cpp that calls the new stub seems to have fixed it 👍
Comment 8 EWS 2023-09-07 15:44:46 PDT 
Committed 267755@main (d222062cd5d9): <https://commits.webkit.org/267755@main>

Reviewed commits have been landed. Closing PR #17553 and removing active labels.