Bug 261236 - [ iOS wk2 ] Unskip layout tests exercising caps lock toggling in password fields
Summary: [ iOS wk2 ] Unskip layout tests exercising caps lock toggling in password fields
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Abrar Rahman Protyasha
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-06 15:23 PDT by Abrar Rahman Protyasha
Modified: 2023-09-06 17:33 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Abrar Rahman Protyasha 2023-09-06 15:23:36 PDT 
Namely, we skipped:

1. fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-after-hiding-auto-fill-strong-password-button.html
2. fast/forms/auto-fill-button/caps-lock-indicator-should-not-be-visible-when-auto-fill-strong-password-button-is-visible.html
3. fast/forms/password-scrolled-after-caps-lock-toggled.html

on ios-wk2 because WebKit did not know when a modifier key was pressed in an editable field. This is no longer the case, and as such we should unskip these tests.
Comment 1 Radar WebKit Bug Importer 2023-09-06 15:23:56 PDT 
<rdar://problem/115079481>
Comment 2 Abrar Rahman Protyasha 2023-09-06 15:29:11 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17508
Comment 3 EWS 2023-09-06 17:33:33 PDT 
Committed 267707@main (3aeb22683ac3): <https://commits.webkit.org/267707@main>

Reviewed commits have been landed. Closing PR #17508 and removing active labels.