Bug 261237 - AX: title-attribute-used-as-last-resort fails in ITM
Summary: AX: title-attribute-used-as-last-resort fails in ITM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-06 15:27 PDT by Joshua Hoffman
Modified: 2023-09-07 16:21 PDT (History)
11 users (show)

See Also:

Attachments
Patch (8.83 KB, patch)
2023-09-06 16:23 PDT, Joshua Hoffman 		no flags Details | Formatted Diff | Diff
Patch (8.64 KB, patch)
2023-09-07 09:07 PDT, Joshua Hoffman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Hoffman 2023-09-06 15:27:55 PDT 
When run in isolated tree mode, the Mac/title-attribute-used-as-last-resort.html test fails.
Comment 1 Radar WebKit Bug Importer 2023-09-06 15:28:03 PDT 
<rdar://problem/115079675>
Comment 2 Joshua Hoffman 2023-09-06 16:23:32 PDT 
Created attachment 467577 [details]
Patch
Comment 3 Tyler Wilcock 2023-09-07 00:00:55 PDT 
Comment on attachment 467577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467577&action=review

> LayoutTests/accessibility/mac/title-attribute-used-as-last-resort.html:28
> +        document.getElementById("link2").focus()

Looks like this patch removes some semicolons after .focus() calls, but our code style prefers to have them.
Comment 4 Joshua Hoffman 2023-09-07 09:00:20 PDT 
Comment on attachment 467577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467577&action=review

>> LayoutTests/accessibility/mac/title-attribute-used-as-last-resort.html:28
>> +        document.getElementById("link2").focus()
> 
> Looks like this patch removes some semicolons after .focus() calls, but our code style prefers to have them.

ah yep—I'll fix that!
Comment 5 Joshua Hoffman 2023-09-07 09:07:14 PDT 
Created attachment 467588 [details]
Patch
Comment 6 EWS 2023-09-07 16:21:07 PDT 
Committed 267757@main (93abe637e908): <https://commits.webkit.org/267757@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467588 [details].