Bug 261240 - [Xcode] Track "Additional Resources" copied from WebKitAdditions
Summary: [Xcode] Track "Additional Resources" copied from WebKitAdditions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-06 16:27 PDT by Elliott Williams
Modified: 2023-09-07 14:00 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2023-09-06 16:27:01 PDT 
Currently, they are copied by a script phase that runs `ditto`. This can’t be properly incrementalized, because Xcode doesn’t know which files are being copied. In its current state, it causes WebKit’s module verifier to re-run spuriously, even though there are no resources being copied.
Comment 1 Elliott Williams 2023-09-06 16:27:07 PDT 
<rdar://problem/115082280>
Comment 2 Elliott Williams 2023-09-06 17:29:57 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17520
Comment 3 EWS 2023-09-07 14:00:34 PDT 
Committed 267747@main (a5cc5d4900a0): <https://commits.webkit.org/267747@main>

Reviewed commits have been landed. Closing PR #17520 and removing active labels.