Bug 261290 - [css-grid] Consider fallback alignment for first and last baseline in RenderGrid::columnAxisPositionForChild
Summary: [css-grid] Consider fallback alignment for first and last baseline in RenderG...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks: 260570
  Show dependency tree / graph
 
Reported: 2023-09-07 14:25 PDT by Sammy Gill
Modified: 2023-09-08 14:50 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-09-07 14:25:50 PDT 
Instead of mapping first baseline to grid axis start and last baseline to grid axis end, we need to consider the fallback alignment of the grid items

https://drafts.csswg.org/css-align-3/#align-by-baseline
Comment 1 Radar WebKit Bug Importer 2023-09-07 14:26:16 PDT 
<rdar://problem/115136343>
Comment 2 Sammy Gill 2023-09-07 14:35:04 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17555
Comment 3 EWS 2023-09-08 14:50:41 PDT 
Committed 267811@main (256590954964): <https://commits.webkit.org/267811@main>

Reviewed commits have been landed. Closing PR #17555 and removing active labels.