Bug 261296 - Associate a purpose for each GraphicsContextState in the context state stack
Summary: Associate a purpose for each GraphicsContextState in the context state stack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 225349
  Show dependency tree / graph
 
Reported: 2023-09-07 15:09 PDT by Said Abou-Hallawa
Modified: 2024-02-05 09:13 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-09-07 15:09:19 PDT 
We internally call GraphicsContext::save() when we begin a transparency layer and we call GraphicsContext::restore() when we end the transparency layer.

Differentiating when this happens from normal save/restore will make it easy to unwind the stack of the GraphicsContextState and the transparency layers in the right order.
Comment 1 Radar WebKit Bug Importer 2023-09-07 15:11:18 PDT 
<rdar://problem/115138846>
Comment 2 Said Abou-Hallawa 2023-09-07 15:16:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17557
Comment 3 EWS 2023-09-08 07:35:43 PDT 
Committed 267790@main (7d3126b3705a): <https://commits.webkit.org/267790@main>

Reviewed commits have been landed. Closing PR #17557 and removing active labels.
Comment 4 Said Abou-Hallawa 2023-09-08 11:13:27 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/17603
Comment 5 EWS 2023-09-08 11:18:03 PDT 
Test gardening commit 267803@main (dd7184450022): <https://commits.webkit.org/267803@main>

Reviewed commits have been landed. Closing PR #17603 and removing active labels.