Bug 261365 - [IFC][Partial layout] Enable appending inline box content
Summary: [IFC][Partial layout] Enable appending inline box content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-08 19:45 PDT by zalan
Modified: 2023-09-11 19:52 PDT (History)
12 users (show)

See Also:


Attachments
Patch (12.16 KB, patch)
2023-09-08 20:07 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (12.16 KB, patch)
2023-09-09 08:22 PDT, zalan
no flags Details | Formatted Diff | Diff
[fast-cq]Patch (13.50 KB, patch)
2023-09-09 17:09 PDT, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-09-08 19:45:22 PDT
ssia
Comment 1 zalan 2023-09-08 20:07:32 PDT
Created attachment 467615 [details]
Patch
Comment 2 zalan 2023-09-09 08:22:18 PDT
Created attachment 467620 [details]
Patch
Comment 3 zalan 2023-09-09 17:09:35 PDT
Created attachment 467626 [details]
[fast-cq]Patch
Comment 4 EWS 2023-09-09 21:21:17 PDT
Committed 267837@main (4f581efcb106): <https://commits.webkit.org/267837@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467626 [details].
Comment 5 Radar WebKit Bug Importer 2023-09-09 21:22:29 PDT
<rdar://problem/115236862>
Comment 6 Fujii Hironori 2023-09-11 13:38:25 PDT
fast/canvas/imageData-consistency.html is timing out after 267837@main.
https://results.webkit.org/?suite=layout-tests&test=fast%2Fcanvas%2FimageData-consistency.html
Comment 7 zalan 2023-09-11 13:44:16 PDT
Thank you, will look into it!
Comment 8 zalan 2023-09-11 15:58:44 PDT
we run partial layout on this test but figuring out whether we _can_ is expensive ( LineLayout::contentNeedsVisualReordering iterates through the box tree and this test generates over 30K boxes)
Comment 9 zalan 2023-09-11 19:52:47 PDT
bug 261452 addresses the timeout