Bug 261423 - [ EWS macOS WK1 ] run-layout-tests-in-stress-mode always runs tests in WK2 (with WKTR)
Summary: [ EWS macOS WK1 ] run-layout-tests-in-stress-mode always runs tests in WK2 (w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-11 12:03 PDT by Abrar Rahman Protyasha
Modified: 2023-09-21 08:40 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Abrar Rahman Protyasha 2023-09-11 12:03:27 PDT 
It looks like the run-layout-tests-in-stress-mode is unconditionally running layout tests with WebKitTestRunner (WK2), even on a WK1 bot. This was an unexpected revelation as I was debugging a EWS failure recently on the macOS-Monterey-Release-WK1-Tests-EWS bot: https://ews-build.webkit.org/#/builders/10/builds/15732

Notice that the output log of the run-layout-tests-in-stress-mode stage from the linked job reads (unexpectedly):

```
Using port 'mac-monterey-wk2'
```

Whereas the output log of the layout-tests stage from the same job reads (as expected):

```
Using port 'mac-monterey'
```
Comment 1 Radar WebKit Bug Importer 2023-09-18 12:04:13 PDT 
<rdar://problem/115672166>
Comment 2 Brianna Fan 2023-09-19 14:53:20 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17935
Comment 3 EWS 2023-09-21 08:40:12 PDT 
Committed 268254@main (6d5c08794a57): <https://commits.webkit.org/268254@main>

Reviewed commits have been landed. Closing PR #17935 and removing active labels.