Bug 261428 - AX ITM: Not necessary to cache IsFocused in isolated objects.
Summary: AX ITM: Not necessary to cache IsFocused in isolated objects.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-11 14:03 PDT by Andres Gonzalez
Modified: 2023-09-12 09:09 PDT (History)
11 users (show)

See Also:

Attachments
Patch (7.69 KB, patch)
2023-09-11 14:08 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (7.74 KB, patch)
2023-09-12 05:50 PDT, Andres Gonzalez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2023-09-11 14:03:00 PDT 
.
Comment 1 Radar WebKit Bug Importer 2023-09-11 14:03:11 PDT 
<rdar://problem/115312448>
Comment 2 Andres Gonzalez 2023-09-11 14:08:29 PDT 
Created attachment 467647 [details]
Patch
Comment 3 Tyler Wilcock 2023-09-11 16:16:18 PDT 
Comment on attachment 467647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467647&action=review

> COMMIT_MESSAGE:7
> +Instead of caching this property and updating it, this patch changes the implementation of AXIsolatedObject::isFocused() to use the tree's focused object ID. this guaranties consistency between the methods isFocuse() and focusedUIElement, i.e., isFocused() will return true if and only if the object is the unique focus.

> this guaranties
this should probably be capitalized, and guaranties looks like a typo. isFocuse() is another likely typo.
Comment 4 Andres Gonzalez 2023-09-12 05:50:10 PDT 
Created attachment 467658 [details]
Patch
Comment 5 EWS 2023-09-12 07:30:15 PDT 
Committed 267901@main (435613e4bde1): <https://commits.webkit.org/267901@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467658 [details].