Bug 261455 - [IFC][Cleanup] canUseForStyle only checks block level style
Summary: [IFC][Cleanup] canUseForStyle only checks block level style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-11 20:26 PDT by zalan
Modified: 2023-09-12 07:51 PDT (History)
11 users (show)

See Also:

Attachments
Patch (12.10 KB, patch)
2023-09-11 20:33 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.10 KB, patch)
2023-09-12 06:42 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (11.98 KB, patch)
2023-09-12 07:14 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-09-11 20:26:31 PDT 
rename it to canUseForBlockStyle
Comment 1 zalan 2023-09-11 20:33:15 PDT 
Created attachment 467656 [details]
Patch
Comment 2 Antti Koivisto 2023-09-12 06:24:03 PDT 
Comment on attachment 467656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467656&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:266
> +static OptionSet<AvoidanceReason> canUseForBlockStyle(const RenderElement& blockContainer, IncludeReasons includeReasons)

Could be RenderBlockFlow&
Comment 3 zalan 2023-09-12 06:42:12 PDT 
Created attachment 467660 [details]
Patch
Comment 4 zalan 2023-09-12 06:57:16 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 467656 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467656&action=review
> 
> > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:266
> > +static OptionSet<AvoidanceReason> canUseForBlockStyle(const RenderElement& blockContainer, IncludeReasons includeReasons)
> 
> Could be RenderBlockFlow&
good point!
Comment 5 zalan 2023-09-12 07:14:47 PDT 
Created attachment 467662 [details]
[fast-cq]Patch
Comment 6 EWS 2023-09-12 07:50:42 PDT 
Committed 267902@main (7496adff3156): <https://commits.webkit.org/267902@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467662 [details].
Comment 7 Radar WebKit Bug Importer 2023-09-12 07:51:13 PDT 
<rdar://problem/115356083>