RESOLVED FIXED261455
[IFC][Cleanup] canUseForStyle only checks block level style 
https://bugs.webkit.org/show_bug.cgi?id=261455
Summary [IFC][Cleanup] canUseForStyle only checks block level style
alan
Reported 2023-09-11 20:26:31 PDT
rename it to canUseForBlockStyle
Attachments
Patch (12.10 KB, patch)
2023-09-11 20:33 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (12.10 KB, patch)
2023-09-12 06:42 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (11.98 KB, patch)
2023-09-12 07:14 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-09-11 20:33:15 PDT
Created attachment 467656 [details] Patch
Antti Koivisto
Comment 2 2023-09-12 06:24:03 PDT
Comment on attachment 467656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467656&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:266 > +static OptionSet<AvoidanceReason> canUseForBlockStyle(const RenderElement& blockContainer, IncludeReasons includeReasons) Could be RenderBlockFlow&
alan
Comment 3 2023-09-12 06:42:12 PDT
Created attachment 467660 [details] Patch
alan
Comment 4 2023-09-12 06:57:16 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 467656 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467656&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:266 > > +static OptionSet<AvoidanceReason> canUseForBlockStyle(const RenderElement& blockContainer, IncludeReasons includeReasons) > > Could be RenderBlockFlow& good point!
alan
Comment 5 2023-09-12 07:14:47 PDT
Created attachment 467662 [details] [fast-cq]Patch
EWS
Comment 6 2023-09-12 07:50:42 PDT
Committed 267902@main (7496adff3156): <https://commits.webkit.org/267902@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467662 [details].
Radar WebKit Bug Importer
Comment 7 2023-09-12 07:51:13 PDT
<rdar://problem/115356083>
Note You need to log in before you can comment on or make changes to this bug.