Bug 261468 - Basic support for CSS based Ruby in IFC
Summary: Basic support for CSS based Ruby in IFC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
: 44515 (view as bug list)
Depends on:
Blocks: 44515
  Show dependency tree / graph
 
Reported: 2023-09-12 10:41 PDT by Antti Koivisto
Modified: 2023-10-08 11:17 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2023-09-12 10:41:27 PDT 
The current Ruby implementation uses special elements and renderers. Implement CSS based ruby in IFC.
Comment 1 Radar WebKit Bug Importer 2023-09-12 10:42:04 PDT 
<rdar://problem/115370429>
Comment 2 Antti Koivisto 2023-09-12 11:59:54 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17700
Comment 3 EWS 2023-09-13 01:25:12 PDT 
Committed 267937@main (44bf0d71007c): <https://commits.webkit.org/267937@main>

Reviewed commits have been landed. Closing PR #17700 and removing active labels.
Comment 4 Claudio Saavedra 2023-09-13 06:31:16 PDT 
This is the first commit where the pywebkit tests start failing:

[1673/2234] webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties failed:                                          
  Traceback (most recent call last):
    File "/app/webkit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py", line 267, in test_convert_prefixed_properties
      test_content = self.generate_test_content_properties_and_values(converter.prefixed_properties, converter.prefixed_property_values, 18, test_html)
    File "/app/webkit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py", line 394, in generate_test_content_properties_and_values
      test_content_property_values = self.generate_test_content(fully_property_values_list, num_test_properties_and_values, 'propvalue', test_content_properties[1])
    File "/app/webkit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py", line 398, in generate_test_content
      assert num_test <= len(full_list), "can't generate more tests than we have input data for"
  AssertionError: can't generate more tests than we have input data for

Not familiar with this, but thought I'd let you know.
Comment 5 Tim Nguyen (:ntim) 2023-10-08 11:17:58 PDT 
*** Bug 44515 has been marked as a duplicate of this bug. ***