Bug 261488 - WPT lint tool fails if run from outside the repo
Summary: WPT lint tool fails if run from outside the repo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-12 18:38 PDT by Matt Woodrow
Modified: 2023-09-13 14:10 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-09-12 18:38:27 PDT 
Running export-w3c-tests fails for me with a bunch of lint errors of the form 'file matches an ignore filter in .gitignore'.

It seems that for some reason it ends up passing our new test files to `git check-ignore --stdin' such that the contents of the test file is interpreted as a list of files to check against the ignore list.

Using the web-platform-tests directory as the CWD fixes this issue.
Comment 1 Radar WebKit Bug Importer 2023-09-12 18:38:37 PDT 
<rdar://problem/115400766>
Comment 2 Matt Woodrow 2023-09-12 18:39:43 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17718
Comment 3 EWS 2023-09-13 14:10:43 PDT 
Committed 267967@main (97f8f5512116): <https://commits.webkit.org/267967@main>

Reviewed commits have been landed. Closing PR #17718 and removing active labels.