Bug 261523 - [css-grid] RenderGrid::getBaselineChild should look at both the alignment type of the grid item and its alignment context
Summary: [css-grid] RenderGrid::getBaselineChild should look at both the alignment typ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 260573
  Show dependency treegraph
 
Reported: 2023-09-13 11:41 PDT by Sammy Gill
Modified: 2023-12-12 14:10 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-09-13 11:41:00 PDT
Currently getBaselineChild only looks at the type of alignment for a grid item when determining if it should use it for the grid's baseline. However, it should also be checking the alignment context in which the item is in. For example, a last baseline aligned grid item that spans multiple rows may participate in baseline alignment in the last track is spans into as opposed to the first track it gets placed in
Comment 1 Radar WebKit Bug Importer 2023-09-13 11:41:17 PDT
<rdar://problem/115441833>
Comment 2 Sammy Gill 2023-12-12 14:10:17 PST
https://github.com/WebKit/WebKit/pull/17746