Bug 261576 - [css-grid] Use ShorthandSerializer for grid-row computed style
Summary: [css-grid] Use ShorthandSerializer for grid-row computed style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks: 245729
  Show dependency tree / graph
 
Reported: 2023-09-14 15:08 PDT by Sammy Gill
Modified: 2023-09-19 09:33 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-09-14 15:08:25 PDT 
We are failing some WPT tests for this property in certain scenarios such as when we are not returning the shortest representation for the property value. We can reuse the logic that is in ShorthandSerializer instead of duplicating the logic
Comment 1 Radar WebKit Bug Importer 2023-09-14 15:08:50 PDT 
<rdar://problem/115521465>
Comment 2 Sammy Gill 2023-09-14 16:36:40 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17794
Comment 3 Sammy Gill 2023-09-18 16:37:50 PDT 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/42038
Comment 4 EWS 2023-09-19 09:33:05 PDT 
Committed 268132@main (5780a097f692): <https://commits.webkit.org/268132@main>

Reviewed commits have been landed. Closing PR #17794 and removing active labels.