Bug 261614 - [build.webkit.org] compile-webkit step should fail builds that exceed a predefined threshold of log lines
Summary: [build.webkit.org] compile-webkit step should fail builds that exceed a prede...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-15 11:49 PDT by Aakash Jain
Modified: 2023-09-15 13:08 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2023-09-15 11:49:10 PDT 
Similar to https://bugs.webkit.org/show_bug.cgi?id=261569, for build.webkit.org also, compile-webkit step should fail builds that exceed a predefined threshold of log lines. This can cause buildbot to grind to a halt as it cannot handle the memory / database load.

(This is a subtask of https://bugs.webkit.org/show_bug.cgi?id=249054)

One example was on 2022-04-08 when the buildbot server was extremely slow and returning 502. The cause was huge logging, 
e.g.: 1 million log lines in compile-webkit step in https://build.webkit.org/#/builders/375/builds/3955
Comment 1 Aakash Jain 2023-09-15 11:53:38 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17820
Comment 2 EWS 2023-09-15 13:07:28 PDT 
Committed 268034@main (e6adefb9e862): <https://commits.webkit.org/268034@main>

Reviewed commits have been landed. Closing PR #17820 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-09-15 13:08:20 PDT 
<rdar://problem/115569226>