RESOLVED FIXED261637
[GTK] build breaks with -DUSE_GBM=OFF: WebCore/DMABufFormat.h: No such file or directory 
https://bugs.webkit.org/show_bug.cgi?id=261637
Summary [GTK] build breaks with -DUSE_GBM=OFF: WebCore/DMABufFormat.h: No such file o...
Jim Mason
Reported 2023-09-16 02:09:49 PDT
building 2.42.0 (tarball) -DUSE_GBM=OFF Unguarded inclusion of a GBM-related header breaks compilation of two source files: webkitgtk-2.42.0/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:36:10: fatal error: WebCore/DMABufFormat.h: No such file or directory 36 | #include <WebCore/DMABufFormat.h> webkitgtk-2.42.0/Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp:34:10: fatal error: WebCore/DMABufFormat.h: No such file or directory 34 | #include <WebCore/DMABufFormat.h> Both source files reference one constant from DMABufFormat.h, `WebCore::DMABufFormat::Modifier::Invalid` Build completes normally when the header file and test involving the constant are removed from the source files.
Attachments
Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2023-09-18 02:46:06 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17854
EWS
Comment 2 2023-09-19 01:02:28 PDT
Committed 268112@main (ba13698c64e0): <https://commits.webkit.org/268112@main> Reviewed commits have been landed. Closing PR #17854 and removing active labels.
Thomas Devoogdt
Comment 3 2023-09-27 00:32:40 PDT
There is more here, also #include <epoxy/egl.h> is not a given if USE_OPENGL_OR_ES=OFF and USE_GBM=OFF. webkitgtk-2.42.0/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:39:10: fatal error: epoxy/egl.h: No such file or directory 39 | #include <epoxy/egl.h> | ^~~~~~~~~~~~~
Carlos Garcia Campos
Comment 4 2023-09-27 00:44:53 PDT
(In reply to Thomas Devoogdt from comment #3) > There is more here, also #include <epoxy/egl.h> is not a given if > USE_OPENGL_OR_ES=OFF and USE_GBM=OFF. > > > webkitgtk-2.42.0/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf. > cpp:39:10: fatal error: epoxy/egl.h: No such file or directory > 39 | #include <epoxy/egl.h> > | ^~~~~~~~~~~~~ That's because of USE_OPENGL_OR_ES not GBM. File a new bug report, please.
Thomas Devoogdt
Comment 5 2023-09-27 01:10:25 PDT
New bug report: https://bugs.webkit.org/show_bug.cgi?id=262169.
Note You need to log in before you can comment on or make changes to this bug.