Bug 261646 - AX: Computed role of role="form" and role="region" elements does not dynamically update when label changes
Summary: AX: Computed role of role="form" and role="region" elements does not dynamica...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-16 19:01 PDT by Tyler Wilcock
Modified: 2023-09-18 11:00 PDT (History)
10 users (show)

See Also:

Attachments
Patch (8.75 KB, patch)
2023-09-16 19:06 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (8.81 KB, patch)
2023-09-17 10:53 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (8.80 KB, patch)
2023-09-18 00:18 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2023-09-16 19:01:12 PDT 
...
Comment 1 Radar WebKit Bug Importer 2023-09-16 19:01:26 PDT 
<rdar://problem/115608740>
Comment 2 Tyler Wilcock 2023-09-16 19:06:06 PDT 
Created attachment 467709 [details]
Patch
Comment 3 Tyler Wilcock 2023-09-17 10:53:54 PDT 
Created attachment 467722 [details]
Patch
Comment 4 chris fleizach 2023-09-17 22:32:14 PDT 
Comment on attachment 467722 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467722&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:2459
> +        RefPtr axObject = getOrCreate(element);

do we need to create an object here, or is just getting an existing one sufficient, since other creation methods will get the right value?
Comment 5 Tyler Wilcock 2023-09-18 00:18:41 PDT 
Created attachment 467736 [details]
Patch
Comment 6 Tyler Wilcock 2023-09-18 00:18:56 PDT 
(In reply to chris fleizach from comment #4)
> Comment on attachment 467722 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467722&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:2459
> > +        RefPtr axObject = getOrCreate(element);
> 
> do we need to create an object here, or is just getting an existing one
> sufficient, since other creation methods will get the right value?
Good catch!
Comment 7 EWS 2023-09-18 11:00:10 PDT 
Committed 268087@main (bc6b70cc4367): <https://commits.webkit.org/268087@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467736 [details].