Bug 261669 - [GTK][WPE] Use enable-html5-database runtime flag to control IndexedDB API
Summary: [GTK][WPE] Use enable-html5-database runtime flag to control IndexedDB API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Other Linux
: P2 Normal
Assignee: Przemyslaw Gorszkowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-18 00:42 PDT by Przemyslaw Gorszkowski
Modified: 2023-09-19 12:42 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Przemyslaw Gorszkowski 2023-09-18 00:42:28 PDT
Currently we have enable-html5-database (runtime flag), webkit_settings_set_enable_html5_database/webkit_settings_get_enable_html5_database (API for controlling DatabaseEnabled setting) and DatabaseEnabled (setting) but it is used for "Web SQL Database" (https://www.w3.org/TR/webdatabase/).

After https://bugs.webkit.org/show_bug.cgi?id=245484 we need to add a separate setting and API to control visibility of the indexedDB API.
Comment 1 Michael Catanzaro 2023-09-18 06:44:18 PDT
WebSQL isn't supported anymore so the enable-html5-database only affects IndexedDB nowadays. It should probably be renamed in a future API version.
Comment 2 Przemyslaw Gorszkowski 2023-09-18 06:52:09 PDT
Pull request: https://github.com/WebKit/WebKit/pull/17858
Comment 3 EWS 2023-09-19 12:42:55 PDT
Committed 268142@main (c58657f2f72f): <https://commits.webkit.org/268142@main>

Reviewed commits have been landed. Closing PR #17858 and removing active labels.