Bug 261709 - [PGO] GPUP's executable should not be built for instrumentation
Summary: [PGO] GPUP's executable should not be built for instrumentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-18 16:33 PDT by Elliott Williams
Modified: 2023-09-19 17:09 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2023-09-18 16:33:33 PDT 
Like other XPC services, its use of the WebKit frameworks should be instrumented, but not its main executable. It is missing the CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING build setting that other targets have.
Comment 1 Radar WebKit Bug Importer 2023-09-18 16:34:09 PDT 
<rdar://problem/115688644>
Comment 2 Elliott Williams 2023-09-18 16:37:34 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17885
Comment 3 EWS 2023-09-19 17:09:24 PDT 
Committed 268164@main (f35c6c8e306f): <https://commits.webkit.org/268164@main>

Reviewed commits have been landed. Closing PR #17885 and removing active labels.