Bug 261725 - [PlayStation][Debug] Build fix after 268047@main
Summary: [PlayStation][Debug] Build fix after 268047@main
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yousuke Kimoto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-19 01:27 PDT by Yousuke Kimoto
Modified: 2023-09-19 23:56 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuke Kimoto 2023-09-19 01:27:44 PDT 
With "debug" build, an "unused function" was detected as follows:

19>ThreadingPOSIX.cpp
19>Source\WTF\wtf\posix\ThreadingPOSIX.cpp(268,12): error : unused function 'schedPolicy' [-Werror,-Wunused-function]
19>static int schedPolicy(Thread::SchedulingPolicy schedulingPolicy)

https://github.com/WebKit/WebKit/commit/3468951fe890ae71911f72a444617be38c39c14f added schedPolicy(), which seems
to need to be defined with HAVE_SCHEDULING_POLICIES because the caller is implemented with HAVE(SCHEDULING_POLICIES).

>#if HAVE(SCHEDULING_POLICIES)
>    pthread_attr_setschedpolicy(&attr, schedPolicy(schedulingPolicy));
>#endif

To fix this build break, adding a macro condition for 'schedPolicy()'.
Comment 1 Yousuke Kimoto 2023-09-19 02:17:44 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17904
Comment 2 EWS 2023-09-19 23:55:48 PDT 
Committed 268183@main (2e5b79e639b0): <https://commits.webkit.org/268183@main>

Reviewed commits have been landed. Closing PR #17904 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-09-19 23:56:17 PDT 
<rdar://problem/115769010>