Bug 261756 - enclosingClippingScopes() can be called twice per layer on compositing updates
Summary: enclosingClippingScopes() can be called twice per layer on compositing updates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Compositing (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-19 10:36 PDT by Simon Fraser (smfr)
Modified: 2023-09-19 21:02 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2023-09-19 10:36:30 PDT 
enclosingClippingScopes() does an ancestor tree walk, and shows up in profiles on layer-heavy sites. It's called from both layerOverlaps() and addToOverlapMap(), so we can avoid one of those calls.
Comment 1 Radar WebKit Bug Importer 2023-09-19 10:36:53 PDT 
<rdar://problem/115734407>
Comment 2 Simon Fraser (smfr) 2023-09-19 10:41:09 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17924
Comment 3 EWS 2023-09-19 21:02:36 PDT 
Committed 268176@main (6d84ae083179): <https://commits.webkit.org/268176@main>

Reviewed commits have been landed. Closing PR #17924 and removing active labels.