Bug 261852 - [WebGPU] https://webgpu.github.io/webgpu-samples/samples/renderBundles does not load
Summary: [WebGPU] https://webgpu.github.io/webgpu-samples/samples/renderBundles does n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-20 16:22 PDT by Mike Wyrzykowski
Modified: 2023-09-26 08:39 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Wyrzykowski 2023-09-20 16:22:24 PDT
https://webgpu.github.io/webgpu-samples/samples/renderBundles does not load due to:

MSL compilation error: Error Domain=MTLLibraryErrorDomain Code=3 "program_source:65:48: error: call to 'max' is ambiguous
    vec<float, 3> local8 = saturate((local5 + (max(dot(local3.normal, local6), 0) * local7)));


corresponding MSL:
  vec<float, 3> local8 = saturate((local5 + (max(dot(local3.normal, local6), 0) * local7)));

corresponding WGSL:
  let lightColor = saturate(ambientColor + max(dot(input.normal, lightDir), 0.0) * dirColor);

looks like the ".0" is being dropped, if we kept it, it would compile or at least not fail at this line
Comment 1 Radar WebKit Bug Importer 2023-09-20 16:22:45 PDT
<rdar://problem/115810432>
Comment 2 Mike Wyrzykowski 2023-09-25 14:20:25 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18188
Comment 3 EWS 2023-09-26 08:39:16 PDT
Committed 268454@main (0b7d33831395): <https://commits.webkit.org/268454@main>

Reviewed commits have been landed. Closing PR #18188 and removing active labels.