Bug 261890 - [WebGPU] fragmentWriteGBuffers.wgsl does not compile
Summary: [WebGPU] fragmentWriteGBuffers.wgsl does not compile
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-21 10:33 PDT by Mike Wyrzykowski
Modified: 2023-09-26 00:23 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Wyrzykowski 2023-09-21 10:33:21 PDT
fragmentWriteGBuffers.wgsl from https://webgpu.github.io/webgpu-samples/samples/deferredRendering#fragmentWriteGBuffers.wgsl does not compile because it writes to multiple render targets and the locations are not specified.

I.e., in the generated output:

struct type0 {
    vec<float, 4> normal ;
    vec<float, 4> albedo ;
};

should be:

struct type0 {
    vec<float, 4> normal [[color(0)]];
    vec<float, 4> albedo [[color(1)]];
};
Comment 1 Radar WebKit Bug Importer 2023-09-21 10:33:38 PDT
<rdar://problem/115849432>
Comment 2 Tadeu Zagallo 2023-09-25 08:14:17 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18159
Comment 3 EWS 2023-09-26 00:23:17 PDT
Committed 268436@main (255232f837a9): <https://commits.webkit.org/268436@main>

Reviewed commits have been landed. Closing PR #18159 and removing active labels.