WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
261899
Remove warnings in NativePromise when both log and release log are disabled.
https://bugs.webkit.org/show_bug.cgi?id=261899
Summary
Remove warnings in NativePromise when both log and release log are disabled.
Stephan Szabo
Reported
2023-09-21 12:02:58 PDT
At least on LLVM17, we get warnings for a few methods in NativePromise about unused arguments that are used in logging statements when both LOG_DISABLED and RELEASE_LOG_DISABLED are true. Putting in UNUSED_PARAMs similar to resolve seemed to work for us.
Attachments
Add attachment
proposed patch, testcase, etc.
Stephan Szabo
Comment 1
2023-09-21 12:05:02 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/18034
EWS
Comment 2
2023-09-22 10:17:09 PDT
Committed
268318@main
(c24c48984502): <
https://commits.webkit.org/268318@main
> Reviewed commits have been landed. Closing PR #18034 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-09-22 10:18:15 PDT
<
rdar://problem/115900146
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug