Bug 261902 - Have RenderObject subclass CanMakeCheckedPtr
Summary: Have RenderObject subclass CanMakeCheckedPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-21 12:37 PDT by Chris Dumez
Modified: 2023-09-21 20:03 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-09-21 12:37:23 PDT 
Have RenderObject subclass CanMakeCheckedPtr so that we can adopt CheckedPtr / CheckedRef in rendering code for safety.
We were previously relying on WeakPtr but it turned out to be too costly and cause performance regressions.
Comment 1 Chris Dumez 2023-09-21 12:40:08 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18036
Comment 2 EWS 2023-09-21 20:02:26 PDT 
Committed 268298@main (60da0af82782): <https://commits.webkit.org/268298@main>

Reviewed commits have been landed. Closing PR #18036 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-09-21 20:03:20 PDT 
<rdar://problem/115874373>