Bug 261907 - [build.webkit.org] Use passwords.json instead of environment variables
Summary: [build.webkit.org] Use passwords.json instead of environment variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-21 15:26 PDT by Aakash Jain
Modified: 2023-10-18 12:25 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2023-09-21 15:26:04 PDT
[build.webkit.org] Use passwords.json instead of environment variables.
Comment 1 Aakash Jain 2023-09-21 15:26:19 PDT
rdar://115659344
Comment 2 Aakash Jain 2023-09-21 15:27:18 PDT
This is good for security as well, in case of accidental leak of env variables.
Comment 3 Aakash Jain 2023-09-21 15:31:35 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18045
Comment 4 EWS 2023-09-21 15:45:45 PDT
Committed 268277@main (6e0343960caf): <https://commits.webkit.org/268277@main>

Reviewed commits have been landed. Closing PR #18045 and removing active labels.