Bug 261960 - Create a combined GTK/WPE PlatformEnablement file
Summary: Create a combined GTK/WPE PlatformEnablement file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-22 11:07 PDT by Brent Fulgham
Modified: 2023-09-27 16:07 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2023-09-22 11:07:03 PDT
The design of the build enablement flags is for PlatformEnable.h to contain the default state of flags, and for individual ports to have specific files that control the state on those platforms (assuming they do not want the default behavior).

In general, features should start of enabled in some ports and not others, then be enabled on all ports, then eventually the compile option is removed and all ports just build it all the time.

We have dedicated files for Playstation, Cocoa, and Windows, but the GTK/WPE port flags live inside the main PlatformEnable header, leading to confusion and encouraging developers to add more conditional flags in that "default" file.

This patch adds a new PlatformEnableGTKWPE.h file that moves the relevant flags, and tidies up the primary file.
Comment 1 Radar WebKit Bug Importer 2023-09-22 11:07:14 PDT
<rdar://problem/115902210>
Comment 2 Brent Fulgham 2023-09-22 16:36:08 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18109
Comment 3 EWS 2023-09-27 16:07:49 PDT
Committed 268543@main (73e0d4c74d1b): <https://commits.webkit.org/268543@main>

Reviewed commits have been landed. Closing PR #18109 and removing active labels.