Bug 261980 - [git-webkit] Reference all identity commits in pickable
Summary: [git-webkit] Reference all identity commits in pickable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-22 15:25 PDT by Jonathan Bedard
Modified: 2023-09-22 16:36 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-09-22 15:25:07 PDT
When checking if a commit is pickable, our current implementation stops at the first identity. This doesn't work well when we start cherry-picking cherry-picks. Instead, we should check all identity commits.
Comment 1 Radar WebKit Bug Importer 2023-09-22 15:25:19 PDT
<rdar://problem/115912222>
Comment 2 Jonathan Bedard 2023-09-22 15:27:18 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18106
Comment 3 EWS 2023-09-22 15:58:01 PDT
Committed 268340@main (4c8538afb2f3): <https://commits.webkit.org/268340@main>

Reviewed commits have been landed. Closing PR #18106 and removing active labels.
Comment 4 EWS 2023-09-22 16:27:04 PDT
Committed 265870.585@safari-7616-branch (2de3b2f30878): <https://commits.webkit.org/265870.585@safari-7616-branch>

Reviewed commits have been landed. Closing PR #794 and removing active labels.
Comment 5 EWS 2023-09-22 16:36:17 PDT
Committed 267815.98@safari-7617-branch (5803b1dcf449): <https://commits.webkit.org/267815.98@safari-7617-branch>

Reviewed commits have been landed. Closing PR #795 and removing active labels.